Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

klavaro: 3.08 -> 3.10 #89352

Merged
merged 1 commit into from Jun 3, 2020
Merged

klavaro: 3.08 -> 3.10 #89352

merged 1 commit into from Jun 3, 2020

Conversation

davidak
Copy link
Member

@davidak davidak commented Jun 2, 2020 •
edited

Motivation for this change

Update and fixes

Screenshot from 2020-05-28 00 44 18

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc maintainer @mimame

@davidak davidak requested a review from mimame June 2, 2020 10:25
@davidak davidak mentioned this pull request Jun 2, 2020
Closed
10 tasks
drewrisinger
drewrisinger suggested changes Jun 2, 2020
View reviewed changes
Copy link
Contributor

@drewrisinger drewrisinger left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Squash 3.09 & 3.10 commits (could honestly squash all these commits together)
  • Rename PR to something like klavaro: 3.08 -> 3.10
  • Haven't tested build locally

pkgs/games/klavaro/default.nix Outdated Show resolved Hide resolved
pkgs/games/klavaro/default.nix Show resolved Hide resolved
pkgs/games/klavaro/default.nix Outdated Show resolved Hide resolved
@davidak
klavaro: 3.08 -> 3.10
9a36fe9 
also fixes and cleanup
@davidak davidak changed the title Klavaro10 klavaro: 3.08 -> 3.10 Jun 2, 2020
@davidak
Copy link
Member Author

davidak commented Jun 2, 2020

@drewrisinger you can test with:

nix run -f https://api.github.com/repos/davidak/nixpkgs/tarball/klavaro10 klavaro

@drewrisinger
Copy link
Contributor

drewrisinger commented Jun 2, 2020 •
edited

Had the following issue on Ubuntu 18.04 (x86-64) using nix-review pr 89352, but had similar issues with GUI apps before. Would appreciate an independent tester on NixOS @mimame

$ nix-shell /home/.../.cache/nixpkgs-review/pr-89352/shell.nix

[nix-shell:~/.cache/nixpkgs-review/pr-89352]$ klavaro

(process:8519): Gtk-WARNING **: 10:18:52.985: Locale not supported by C library.
        Using the fallback 'C' locale.
Gtk-Message: 10:18:53.009: Failed to load module "canberra-gtk-module"
Gtk-Message: 10:18:53.010: Failed to load module "canberra-gtk-module"

(klavaro:8519): Gtk-WARNING **: 10:18:53.295: Could not load image 'other.png': Unable to load image-loading module: /snap/code/31/usr/lib/x86_64-linux-gnu/gdk-pixbuf-2.0/2.10.0/loaders/libpixbufloader-png.so: /snap/code/31/usr/lib/x86_64-linux-gnu/gdk-pixbuf-2.0/2.10.0/loaders/libpixbufloader-png.so: cannot open shared object file: No such file or directory

(klavaro:8519): Gtk-WARNING **: 10:18:53.345: Could not load a pixbuf from icon theme.
This may indicate that pixbuf loaders or the mime database could not be found.

(klavaro:8519): Gtk-WARNING **: 10:18:53.364: Could not load image 'key.png': Unable to load image-loading module: /snap/code/31/usr/lib/x86_64-linux-gnu/gdk-pixbuf-2.0/2.10.0/loaders/libpixbufloader-png.so: /snap/code/31/usr/lib/x86_64-linux-gnu/gdk-pixbuf-2.0/2.10.0/loaders/libpixbufloader-png.so: cannot open shared object file: No such file or directory

(klavaro:8519): Gtk-WARNING **: 10:18:53.365: Could not load image 'altcolor.png': Unable to load image-loading module: /snap/code/31/usr/lib/x86_64-linux-gnu/gdk-pixbuf-2.0/2.10.0/loaders/libpixbufloader-png.so: /snap/code/31/usr/lib/x86_64-linux-gnu/gdk-pixbuf-2.0/2.10.0/loaders/libpixbufloader-png.so: cannot open shared object file: No such file or directory

(klavaro:8519): Gtk-WARNING **: 10:18:53.366: Could not load image 'progress.png': Unable to load image-loading module: /snap/code/31/usr/lib/x86_64-linux-gnu/gdk-pixbuf-2.0/2.10.0/loaders/libpixbufloader-png.so: /snap/code/31/usr/lib/x86_64-linux-gnu/gdk-pixbuf-2.0/2.10.0/loaders/libpixbufloader-png.so: cannot open shared object file: No such file or directory

(klavaro:8519): Gtk-WARNING **: 10:18:53.366: Could not load image 'top10.png': Unable to load image-loading module: /snap/code/31/usr/lib/x86_64-linux-gnu/gdk-pixbuf-2.0/2.10.0/loaders/libpixbufloader-png.so: /snap/code/31/usr/lib/x86_64-linux-gnu/gdk-pixbuf-2.0/2.10.0/loaders/libpixbufloader-png.so: cannot open shared object file: No such file or directory
**
Gtk:ERROR:../gtk/gtkiconhelper.c:494:ensure_surface_for_gicon: assertion failed (error == NULL): Failed to load /usr/share/icons/gnome/16x16/status/image-missing.png: Unable to load image-loading module: /snap/code/31/usr/lib/x86_64-linux-gnu/gdk-pixbuf-2.0/2.10.0/loaders/libpixbufloader-png.so: /snap/code/31/usr/lib/x86_64-linux-gnu/gdk-pixbuf-2.0/2.10.0/loaders/libpixbufloader-png.so: cannot open shared object file: No such file or directory (gdk-pixbuf-error-quark, 5)
Bail out! Gtk:ERROR:../gtk/gtkiconhelper.c:494:ensure_surface_for_gicon: assertion failed (error == NULL): Failed to load /usr/share/icons/gnome/16x16/status/image-missing.png: Unable to load image-loading module: /snap/code/31/usr/lib/x86_64-linux-gnu/gdk-pixbuf-2.0/2.10.0/loaders/libpixbufloader-png.so: /snap/code/31/usr/lib/x86_64-linux-gnu/gdk-pixbuf-2.0/2.10.0/loaders/libpixbufloader-png.so: cannot open shared object file: No such file or directory (gdk-pixbuf-error-quark, 5)
Aborted (core dumped)

@davidak
Copy link
Member Author

davidak commented Jun 2, 2020

@drewrisinger we can get it working on other systems later. the program should also work on windows and mac

any idea why it tries to open /snap/code/31/usr/lib/x86_64-linux-gnu/gdk-pixbuf-2.0/2.10.0/loaders/libpixbufloader-png.so?

@drewrisinger
Copy link
Contributor

nixpkgs-review must not be creating a pure shell, I must have some dependencies installed as Snaps.

I don't particularly care about this application, mostly just trying to review & confirm that the GUI app is working before approving.

@Ma27 Ma27 merged commit 71adcb7 into NixOS:master Jun 3, 2020
@davidak davidak deleted the klavaro10 branch June 3, 2020 09:51
@infinisil infinisil mentioned this pull request Aug 22, 2020
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 left review comments

@drewrisinger drewrisinger drewrisinger requested changes

@mimame mimame Awaiting requested review from mimame

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@davidak @drewrisinger @Ma27