libssh2: fix broken patch hash #89326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Patches from direct URLs on github are not stable (comment headers change w/ server settings), hence why we usually use `fetchpatch`. In lieu of that, vendor the unstable patch.
bhipple
requested review from
edolstra,
Ericson2314,
FRidh,
infinisil,
jonringer,
matthewbauer,
nbp and
ttuegel
as code owners
ofborg
bot
added
6.topic: golang
6.topic: nixos
6.topic: python
6.topic: qt/kde
6.topic: stdenv
|
Is the patch unstable also when this URL is used? |
|
Probably not that much, but I've certainly seen these parts change on some git upgrades: |
|
Last time I got pissed by such a breakage and didn't want to cause a rebuild nor increase nixpkgs repo size, I created a bit-perfect mirror for that patch. I could add this one as well ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patches from direct URLs on github are not stable (comment headers change w/
server settings), hence why we usually use
fetchpatch. In lieu of that, vendorthe unstable patch.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)