Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct CSS2/css1/c414-flt-fit-000.xht and reference #23904

Merged
merged 1 commit into from Jun 2, 2020

Conversation

gsnedders
Copy link
Member

The reference did not match the test, as it did not have navy everywhere the test had it. This fixes this by removing the navy from both test and reference, as it served no purpose.

Additionally, the test depended upon the width of the nbsp relative to the em-square; having observed this varying, this is now fixed by making the table monospace in both test and reference.

Closes #8834. cc/ @TalbotG given he made most of the review comments before (I don't this contains anything you disagreed with, though?). Note that unlike #8834, this doesn't change any width given browsers seem to be interoperable with what the test already had (and @TalbotG believed correct).

The reference did not match the test, as it did not have navy
everywhere the test had it. This fixes this by removing the navy from
both test and reference, as it served no purpose.

Additionally, the test depended upon the width of the nbsp relative
to the em-square; having observed this varying, this is now fixed by
making the table monospace in both test and reference.
@TalbotG
Copy link
Contributor

TalbotG commented Jun 2, 2020

Sam,
It makes sense to use a monospace font in both the test and the reference.
I also agree with your other changes (  replacing   and the addition of your comment on how wide the non-breaking space is).
I wish I could review+approve your PR but, unfortunately, I do not have such powers.

@gsnedders
Copy link
Member Author

@TalbotG it looks like you have those powers? if you look at the "Files Changed" and click "Review Changes" what do you see?

Copy link
Contributor

@TalbotG TalbotG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve those changes.... with a smiley :)

@TalbotG TalbotG merged commit 1e92a2b into web-platform-tests:master Jun 2, 2020
@gsnedders gsnedders deleted the csnardi-patch-7-redux branch June 2, 2020 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants