Remove MainThreadScrollingReasons::kHasClipRelatedProperty #23900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jun 1, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2225229
branch
4 times, most recently
from
6e4dbaa
to
a1d39c1
Compare
We no longer need to skip composited scrolling for css clip and clip-path since (perhaps) BlinkGenPropertyTrees. In compositor, when we hit test on a layer with special clip/mask, we'll still fallback to main thread hit testing/scrolling because only the main thread knows which area is hit testable. This is achieved by cc::LayerTreeHostImpl::IsInitialScrollHitTestReliable() returning false. Bug: 1074395 Change-Id: I91260b063879812ca82928fe783de25c4b6732a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225229 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Reviewed-by: Robert Flack <flackr@chromium.org> Reviewed-by: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#774232}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2225229
branch
from
a1d39c1
to
803457c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We no longer need to skip composited scrolling for css clip and
clip-path since (perhaps) BlinkGenPropertyTrees.
In compositor, when we hit test on a layer with special clip/mask,
we'll still fallback to main thread hit testing/scrolling because only
the main thread knows which area is hit testable. This is achieved by
cc::LayerTreeHostImpl::IsInitialScrollHitTestReliable() returning false.
Bug: 1074395
Change-Id: I91260b063879812ca82928fe783de25c4b6732a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225229
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#774232}