Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lutris-unwrapped: 0.5.5 -> 0.5.6, fix dialouge crashing bug #91466

Merged
merged 1 commit into from Jun 25, 2020
Merged

lutris-unwrapped: 0.5.5 -> 0.5.6, fix dialouge crashing bug #91466

merged 1 commit into from Jun 25, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Jun 25, 2020 •
edited

Motivation for this change

would crash with:

GLib-GIO-ERROR **: 06:04:50.903: No GSettings schemas are installed on the system

if a dialouge box would open.

closes: #90645

Also:

  • cleaned up expression
  • removed the double wrapping
  • added "distro" package, as lutris would warn about not being able to retrieve host info
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from Chiiruno June 25, 2020 06:23
kira-bruneau
kira-bruneau reviewed Jun 25, 2020
View reviewed changes
Copy link
Contributor

@kira-bruneau kira-bruneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

pkgs/applications/misc/lutris/default.nix Show resolved Hide resolved
pkgs/applications/misc/lutris/default.nix Show resolved Hide resolved
pkgs/applications/misc/lutris/default.nix Show resolved Hide resolved
@jonringer
lutris-unwrapped: 0.5.5 -> 0.5.6, fix dialouge crashing bug
25c9705 
would crash with:
```
GLib-GIO-ERROR **: 06:04:50.903: No GSettings schemas are installed on the system
```

if a dialouge box would open.
@jonringer
Copy link
Contributor Author 

https://github.com/NixOS/nixpkgs/pull/91466
3 packages built:
lutris lutris-free lutris-unwrapped

I think this is a solid improvement on the previous derivation. If other fixes are needed, they can be done in another PR. :)

@jonringer jonringer merged commit 37238ff into NixOS:master Jun 25, 2020
@jonringer jonringer deleted the fix-lutris branch June 25, 2020 19:28
@kira-bruneau kira-bruneau mentioned this pull request Jul 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar left review comments

@kira-bruneau kira-bruneau kira-bruneau approved these changes

@Chiiruno Chiiruno Awaiting requested review from Chiiruno

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lutris: crashes when trying to open a file selection dialog
3 participants
@jonringer @kira-bruneau @jtojnar