Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlPackages.buildOasis: fix handling of installation prefix #91465

Merged
merged 1 commit into from Jul 2, 2020
Merged

ocamlPackages.buildOasis: fix handling of installation prefix #91465

merged 1 commit into from Jul 2, 2020

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Jun 25, 2020

Motivation for this change

Currently, build of ocaml-ng.ocamlPackages_4_11.tcslib fails with a mysterious sed error:

sed: -e expression #1, char 70: unknown option to `s'

This PR gives correct arguments to the configure script, hence removes the need for patching its results.

cc @mgttlinger

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mgttlinger mgttlinger self-requested a review June 25, 2020 06:06
mgttlinger
mgttlinger approved these changes Jun 25, 2020
View reviewed changes
Copy link
Member

@mgttlinger mgttlinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I didn't know any better when I implemented this originally.

@vbgl
Copy link
Contributor Author

vbgl commented Jun 25, 2020

@GrahamcOfBorg build ocamlPackages.pgsolver ocaml-ng.ocamlPackages_4_11.tcslib

@vbgl vbgl merged commit 885fb14 into NixOS:master Jul 2, 2020
@vbgl vbgl deleted the ocaml-buildoasis-prefix branch July 2, 2020 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgttlinger mgttlinger mgttlinger approved these changes

Assignees
No one assigned
Labels
6.topic: ocaml 8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vbgl @mgttlinger