Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

igraph: 0.7.1 -> 0.8.2 #91473

Merged
merged 3 commits into from Jun 27, 2020
Merged

igraph: 0.7.1 -> 0.8.2 #91473

merged 3 commits into from Jun 27, 2020

Conversation

MostAwesomeDude
Copy link
Contributor

@MostAwesomeDude MostAwesomeDude commented Jun 25, 2020

Refs #90840.

The check phase is now enabled. All tests pass on my machine.

I realized while doing this bump that igraph vendors OpenBLAS, ARPACK,
and GLPK. We can use our versions instead, and igraph builds
successfully, but 34 tests fail. I'm choosing correctness instead of
build times.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Refs NixOS#90840.

The check phase is now enabled. All tests pass on my machine.

I realized while doing this bump that igraph vendors OpenBLAS, ARPACK,
and GLPK. We can use our versions instead, and igraph builds
successfully, but 34 tests fail. I'm choosing correctness instead of
build times.
@MostAwesomeDude
Copy link
Contributor Author

Looks like tests also fail on aarch64. If that's a blocker, then we can disable tests, and in that case, we ought to use nixpkgs instead of vendored libraries. All of that is possible; LMK.

@Ma27
Copy link
Member

Ma27 commented Jun 25, 2020

It should be fine to disable the tests on aarch64 if only the tests are broken. If the package doesn't work there or isn't supported there, we should restrict meta.platforms.

aarch64-linux tests fail on the community builder, so don't build there
until we have more evidence that failing tests are not a problem.
@Ma27 Ma27 merged commit d7e2270 into NixOS:master Jun 27, 2020
@MostAwesomeDude MostAwesomeDude deleted the igraph branch June 28, 2020 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants