New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pythonPackages.debugpy: init at 1.0.0b12 #91448
Conversation
is this meant to be a library (aka |
@jonringer It's meant as both. It's normally used as an application: python -m debugpy --listen localhost:5678 myfile.py but you can also start a server by using it as a library: import debugpy
debugpy.listen(5678)
debugpy.wait_for_client() # blocks execution until client is attached However, it doesn't create a bin wrapper, it must be started with |
I wonder why they didn't do that, it's like 4 lines in a setup.py |
@jonringer It looks like they have an issue open for it. I guess they never got around to it, even though it's trivial. |
On the latest unstable channel, one test seems to be failing for me: |
do you mind posting the failure. if it's specific to the nix sandbox, it's fine to skip it. But test failures may also indicate that something is truely broken. |
Hmm, I can't seem to reproduce the failure right now. I made a fresh Python build with |
@leungbk I can't seem to reproduce the issue either, do you have the commit hash where it was a problem? |
@MetaDark The build failure occurred when I was upgrading my system packages (not the cleanest environment) on the latest I'll bring it up in the future if it comes up again and I figure out how to reproduce. Sorry for the noise. |
@GrahamcOfBorg build python3Packages.debugpy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
diff LGTM
commits LGTM
has tests 👍
https://github.com/NixOS/nixpkgs/pull/91448
3 packages built:
python27Packages.debugpy python37Packages.debugpy python38Packages.debugpy
I think this looks good for now, most of my issues are with upstream not having an "entry_point" in their setup.py. |
Motivation for this change
Fixes #89592
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
dap-mode
in Emacsnix path-info -S
before and after)