Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uvloop: fix tests on python 3.8 #91440

Merged
merged 1 commit into from Jun 24, 2020
Merged

uvloop: fix tests on python 3.8 #91440

merged 1 commit into from Jun 24, 2020

Conversation

gebner
Copy link
Member

@gebner gebner commented Jun 24, 2020

Motivation for this change

uvloop fails to build on python 3.8, breaking several packages.

This skips yet another test. Workaround copied from the debian package: https://salsa.debian.org/python-team/modules/uvloop/-/commit/302a7e8f5a2869e13d0550cd37e7a8f480e79869

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@gebner gebner mentioned this pull request Jun 24, 2020
Merged
10 tasks
@gebner
Copy link
Member Author

gebner commented Jun 24, 2020

@GrahamcOfBorg build python38Packages.uvloop

@ofborg ofborg bot requested a review from costrouc June 24, 2020 20:50
@gebner gebner merged commit 27859f1 into NixOS:master Jun 24, 2020
@OmnipotentEntity OmnipotentEntity mentioned this pull request Jun 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@costrouc costrouc Awaiting requested review from costrouc

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@gebner