obsidian: init at 0.7.3 #91454
Merged
obsidian: init at 0.7.3 #91454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iblech
reviewed
Jun 25, 2020
ConradMearns
commented
Jun 25, 2020
| @@ -19,6 +19,9 @@ appimageTools.wrapType2 rec { | |||
| export XDG_DATA_DIRS=${gsettings-desktop-schemas}/share/gsettings-schemas/${gsettings-desktop-schemas.name}:${gtk3}/share/gsettings-schemas/${gtk3.name}:$XDG_DATA_DIRS | |||
| ''; | |||
|
|
|||
| # Strip version from binary name. | |||
| extraInstallCommands = "mv $out/bin/${name} $out/bin/${pname}"; | |||
There was a problem hiding this comment.
I get mixed results with this... When running nix-build -A obsidian from the root of my cloned nixpkgs folder, the operation works correctly. However, in my /etc/nixos/config, if I import my custom branch and include obsidian, then it remains obsidian-0.7.3
There was a problem hiding this comment.
Found a good example in the notable package. Tested the fix on a seperate branch, got the expected name.
13 tasks
eliandoran
added a commit
to eliandoran/nixpkgs
that referenced
this pull request
Dec 30, 2021
Apparently the last attempt to use `wrapGAppsHook` into `extraPkgs` failed to solve the issue. Found in NixOS#91454 a potential solution that might also work here.
eliandoran
added a commit
to eliandoran/nixpkgs
that referenced
this pull request
Dec 30, 2021
commit 2d26a73 Author: Elian Doran <contact@eliandoran.me> Date: Wed Dec 29 02:00:18 2021 +0200 keeweb: Use alternative solution for GSettings Apparently the last attempt to use `wrapGAppsHook` into `extraPkgs` failed to solve the issue. Found in NixOS#91454 a potential solution that might also work here. commit 9ea5fde Author: Elian Doran <contact@eliandoran.me> Date: Wed Dec 29 01:52:19 2021 +0200 keeweb: Fix open/save dialogs by wrapping GSettings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Adds Obsidian editor version 0.7.3 (#89089)
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)