New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/smartd: add option for notifiction email sender #91432
Conversation
This is a minor change. Should it be merged into |
4236e9f
to
fa2cfd5
Compare
Backporting doesn't really work that way. The BACK part of backporting menas it's already on master. If you just merged this into 20.03, it wouldn't be on master, and would hence be missing on 20.09. Therefore, you need to target master with this PR and backport it in a second PR after this one is merged. Also, this is not really a backport-worthy change imo, since it introduces a new feature instead of fixing a bug or fixing a security vulnerability. |
fa2cfd5
to
56fe9b9
Compare
56fe9b9
to
e38c10e
Compare
Yes! It's probably documented somewhere but I don't know where. You can just place this module anywhere and import it like |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
diff LGTM
I agree with @dasJ that the backport shouldn't happen, but looks good for master
The option description breaks building the docbook.
It should probably have |
@rtldg how do I build docbook? |
figured it out |
Motivation for this change
I have a dedicated robots@domain.tld email I want to use when automatically reporting errors to myself. The current configuration of
services.smartd
requires one to send an email from root@domain.tld ifservices.smartd.notifictions.mail.sender
is configured for msmtp.This new option allows the sender in the email's
From
field to be configured, and usesroot
as default, mirroring present behavior.Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)