Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grafana: 7.0.3 -> 7.0.4 #91503

Merged
merged 1 commit into from Jun 25, 2020
Merged

grafana: 7.0.3 -> 7.0.4 #91503

merged 1 commit into from Jun 25, 2020

Conversation

Frostman
Copy link
Member

@Frostman Frostman commented Jun 25, 2020

Motivation for this change

https://github.com/grafana/grafana/releases/tag/v7.0.4

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This change is Reviewable

Copy link
Member

@mdlayher mdlayher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

$ nixpkgs-review pr 91503
$ git -c fetch.prune=false fetch --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0 pull/91503/head:refs/nixpkgs-review/1
remote: Enumerating objects: 7, done.
remote: Counting objects: 100% (7/7), done.
remote: Total 7 (delta 5), reused 7 (delta 5), pack-reused 0
Unpacking objects: 100% (7/7), 804 bytes | 804.00 KiB/s, done.
From ssh://github.com/NixOS/nixpkgs
   06f0a0fc27f..860c5ca4a7a  master               -> refs/nixpkgs-review/0
 + dcd48593e84...cb605536649 refs/pull/91503/head -> refs/nixpkgs-review/1  (forced update)
$ git worktree add /home/matt/.cache/nixpkgs-review/pr-91503/nixpkgs 860c5ca4a7a7251b0be741ebe91e7dfe4450c780
Preparing worktree (detached HEAD 860c5ca4a7a)
HEAD is now at 860c5ca4a7a Merge pull request #91495 from ckauhaus/secfix-php
$ git merge --no-commit cb605536649739792282663e7a4645361b2bb924
Automatic merge went well; stopped before committing as requested
$ nix build --no-link --keep-going --option build-use-sandbox relaxed -f /home/matt/.cache/nixpkgs-review/pr-91503/build.nix
[5 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/91503
1 package built:
grafana

$ nix-shell /home/matt/.cache/nixpkgs-review/pr-91503/shell.nix

[nix-shell:~/.cache/nixpkgs-review/pr-91503]$ ./results/grafana/bin/grafana-server -v
Version 7.0.4 (commit: NA, branch: master)

@Ma27 Ma27 merged commit 7a3be96 into NixOS:master Jun 25, 2020
@Frostman Frostman deleted the grafana-7.0.4 branch June 26, 2020 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants