Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util-linux: 2.35.1 -> 2.35.2 #91501

Closed
wants to merge 1 commit into from
Closed

util-linux: 2.35.1 -> 2.35.2 #91501

wants to merge 1 commit into from

Conversation

nlewo
Copy link
Member

@nlewo nlewo commented Jun 25, 2020

Motivation for this change

The growpart NixOS module is currently broken because it seems our cloud-util version requires util-linux 2.35.2: upgrading util-linux fixes the NixOS boot-ec2-nixops test.

Note I didn't test this patch because of the massive rebuild. I instead overrided the growpart module with this util-linux version to check it fixes the issue.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@FRidh
Copy link
Member

FRidh commented Jun 25, 2020

Duplicate of #89043

@FRidh FRidh marked this as a duplicate of #89043 Jun 25, 2020
@FRidh FRidh closed this Jun 25, 2020
@nlewo
Copy link
Member Author

nlewo commented Jun 26, 2020

Oh, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants