Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gomuks: 0.1.0 -> 0.1.2 #91426

Merged
merged 1 commit into from Jun 24, 2020
Merged

gomuks: 0.1.0 -> 0.1.2 #91426

merged 1 commit into from Jun 24, 2020

Conversation

pstn
Copy link
Contributor

@pstn pstn commented Jun 24, 2020 •
edited

# Please do not merge this change yet.
I found a pretty nasty bug while testing the changes. 0.1.0 is the better version to use, until this is resolved. I don't think the bug is nixos-specific since at least one other person in the #gomuks matrix channel came forward immediately with the same problem.

The issue has been fixed with version 0.1.2

Motivation for this change

Bump gomuks version

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • [] Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from kalbasit, tilpner and emilazy June 24, 2020 17:47
@mweinelt
Copy link
Member

You can set the pull request to "Work in progress", which prevents merges.

@pstn pstn changed the title (do not merge) gomuks: 0.1.0 -> 0.1.1 gomuks: 0.1.0 -> 0.1.2 Jun 24, 2020
@Mic92 Mic92 marked this pull request as draft June 24, 2020 21:02
@Mic92
Copy link
Member

Mic92 commented Jun 24, 2020

You can click Ready for review to undraft it again.

@Mic92 Mic92 marked this pull request as ready for review June 24, 2020 21:03
@pstn
Copy link
Contributor Author

pstn commented Jun 24, 2020 •
edited

How do I mark a PR as a draft? (Thanks for doing and reverting it @Mic92 )

edit: Found the button... Well hidden.

@Mic92 Mic92 merged commit e7cc52a into NixOS:master Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit Awaiting requested review from kalbasit

@tilpner tilpner Awaiting requested review from tilpner

@emilazy emilazy Awaiting requested review from emilazy

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pstn @mweinelt @Mic92