Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskellPackages.rdf4h: dontCheck #91420

Merged
merged 2 commits into from Jun 25, 2020
Merged

haskellPackages.rdf4h: dontCheck #91420

merged 2 commits into from Jun 25, 2020

Conversation

svmhdvn
Copy link
Contributor

@svmhdvn svmhdvn commented Jun 24, 2020 •
edited

Motivation for this change

Unbreak rdf4h by skipping tests until robstewart57/rdf4h#39 is resolved.

Fixes #86345

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@svmhdvn svmhdvn marked this pull request as ready for review June 24, 2020 16:56
@cdepillabout
Copy link
Member

Looks like this builds, thanks!

@cdepillabout cdepillabout merged commit 1e0c231 into NixOS:haskell-updates Jun 25, 2020
@svmhdvn svmhdvn deleted the patch-3 branch June 25, 2020 02:19
@cdepillabout cdepillabout mentioned this pull request Jun 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@svmhdvn @cdepillabout