Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] php: 7.2.29 -> 7.2.31, 7.3.16 -> 7.3.19, 7.4.6 -> 7.4.7 #91496

Merged
merged 1 commit into from Jun 25, 2020
Merged

[20.03] php: 7.2.29 -> 7.2.31, 7.3.16 -> 7.3.19, 7.4.6 -> 7.4.7 #91496

merged 1 commit into from Jun 25, 2020

Conversation

ckauhaus
Copy link
Contributor

Motivation for this change

Security and bugfix updates for PHP.

Fixes #88380, #88379, #90939, #90921, #90924, #88382

See #91495 for PR against master.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions Ubuntu
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ckauhaus ckauhaus requested a review from etu as a code owner June 25, 2020 14:33
@ofborg ofborg bot requested a review from globin June 25, 2020 14:42
@Ma27 Ma27 changed the title php: 7.2.29 -> 7.2.31, 7.3.16 -> 7.3.19, 7.4.6 -> 7.4.7 [20.03] php: 7.2.29 -> 7.2.31, 7.3.16 -> 7.3.19, 7.4.6 -> 7.4.7 Jun 25, 2020
@Ma27
Copy link
Member

Ma27 commented Jun 25, 2020

@GrahamcOfBorg build php72 php73 php74

@Ma27
Copy link
Member

Ma27 commented Jun 25, 2020

AFAICS those tests aren't built here (i.e. the changes are only on master). So LGTM 👍

@Ma27 Ma27 merged commit 1517b76 into NixOS:release-20.03 Jun 25, 2020
@ckauhaus ckauhaus deleted the secfix-php-20.03 branch June 30, 2020 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 approved these changes

@etu etu Awaiting requested review from etu etu is a code owner

@globin globin Awaiting requested review from globin

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ckauhaus @Ma27