Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typeguard: fix tests #91451

Merged
merged 1 commit into from Jun 25, 2020
Merged

typeguard: fix tests #91451

merged 1 commit into from Jun 25, 2020

Conversation

callahad
Copy link
Member

Motivation for this change

Typeguard builds are broken due to failing check phase, which breaks python3Packages.tenacity, which breaks the rapid-photo-downloader application, which makes me sad.

This was broken by commit 9993c38; running tests fails with:

Traceback:
tests/test_typeguard_py36.py:7: in <module>
    from typing_extensions import Literal
E   ModuleNotFoundError: No module named 'typing_extensions'

Adding typing-extensions to checkInputs resolves the failure.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@callahad
typeguard: fix tests
40fb898 
Broken by 9993c38

    Traceback:
    tests/test_typeguard_py36.py:7: in <module>
        from typing_extensions import Literal
    E   ModuleNotFoundError: No module named 'typing_extensions'

Resolved by adding typing-extensions to checkInputs
lsix
lsix approved these changes Jun 25, 2020
View reviewed changes
Copy link
Member

@lsix lsix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built and tested.

Thanks!

@lsix lsix merged commit ec1d9c6 into NixOS:master Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsix lsix lsix approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@callahad @lsix