Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

asuka: init at 0.8.0 #91453

Merged
merged 1 commit into from Jun 25, 2020
Merged

asuka: init at 0.8.0 #91453

merged 1 commit into from Jun 25, 2020

Conversation

sikmir
Copy link
Member

@sikmir sikmir commented Jun 25, 2020

Motivation for this change

asuka - Gemini Project client written in Rust with NCurses.
Resolves #87783.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

asuka

danieldk
danieldk suggested changes Jun 25, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just two small nitpicks.

pkgs/applications/networking/browsers/asuka/default.nix Outdated Show resolved Hide resolved
pkgs/applications/networking/browsers/asuka/default.nix Show resolved Hide resolved
danieldk
danieldk approved these changes Jun 25, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

Result of nixpkgs-review pr 91453 1

1 package built:
- asuka

Binary works as expected.

@danieldk danieldk merged commit c864a15 into NixOS:master Jun 25, 2020
@sikmir sikmir deleted the asuka branch June 25, 2020 09:20
@sikmir sikmir mentioned this pull request Jul 16, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Package request: asuka
2 participants
@sikmir @danieldk