cq-editor: fix build #91489
Merged
cq-editor: fix build #91489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FRidh
reviewed
Jun 26, 2020
marcus7070
force-pushed
the
marcus7070/fix-cqeditor
branch
from
9e83dea
to
f63496f
Compare
|
@jonringer, are you able to have a look at the pylint change? |
jonringer
approved these changes
Jul 4, 2020
Yea, this is more correct. Thought the toml package was needed just for reading a |
|
this fixes two previously broken builds LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Will close #91483 and do the
spyder_3half of #91484Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)Unfortunately I can't get cq-editor working with Python 3.8, so I've set it to 3.7.
@jonringer, I see you added toml to pylint's nativeBuildInputs in 27f0dab. I think it needs to be propagated due to the errors in #91484 and https://github.com/PyCQA/pylint/blob/a73585740398052ccd6c67d33869d9049a27e8c7/pylint/__pkginfo__.py#L43 so I've done that in this PR. Is that OK?