Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.progressbar2: Fix checkPhase #91493

Merged
merged 2 commits into from Jun 28, 2020
Merged

pythonPackages.progressbar2: Fix checkPhase #91493

merged 2 commits into from Jun 28, 2020

Conversation

turion
Copy link
Contributor

@turion turion commented Jun 25, 2020

Motivation for this change

Fix #91492 .

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@turion
Copy link
Contributor Author

turion commented Jun 25, 2020

@ashgillman

@ofborg ofborg bot requested a review from ashgillman June 25, 2020 13:47
@turion
Copy link
Contributor Author

turion commented Jun 25, 2020

Unfortunately, this doesn't build for python2:

$ nix-shell -p nixpkgs-review --run "nixpkgs-review pr 91493"
[...]
3 packages failed to build:
python27Packages.progressbar2 python37Packages.baselines truvari

2 packages built:
python37Packages.progressbar2 python38Packages.progressbar2

I don't know how to fix that.

jonringer
jonringer reviewed Jun 25, 2020
View reviewed changes
pkgs/development/python-modules/progressbar2/default.nix
checkPhase = ''
runHook preCheck
${python.interpreter} setup.py test --addopts "--ignore=.eggs"
${python.interpreter} setup.py test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they didn't clean cache files before uploading package, that's why some tests are failing

Suggested change
${python.interpreter} setup.py test
find . -name '*.py[co]' -delete -o -name __pycache__ -delete
${python.interpreter} setup.py test

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made a PR wolph/python-progressbar#231

@jonringer jonringer mentioned this pull request Jun 25, 2020
Closed
@jonringer
Copy link
Contributor

Upstream has released a new patch version with a clean sdist, bumping to the new version should fix this.

@turion
Copy link
Contributor Author

turion commented Jun 26, 2020

@jonringer Thanks! I bumped the version, let's see if it works :)

/marvin opt-in

@marvin-mk2
Copy link

marvin-mk2 bot commented Jun 26, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@marvin-mk2 marvin-mk2 bot added the marvin label Jun 26, 2020
@turion
Copy link
Contributor Author

turion commented Jun 26, 2020

/status needs_review

@turion
Copy link
Contributor Author

turion commented Jun 26, 2020 •
edited

nixpkgs-review still fails because truvari still depends on an older version. See ACEnglish/truvari#52. Also, python37Packages.baselines fails, but because of an unrelated different dependency.

@turion
Copy link
Contributor Author

turion commented Jun 27, 2020

nixpkgs-review still fails because truvari still depends on an older version. See spiralgenetics/truvari#52. Also, python37Packages.baselines fails, but because of an unrelated different dependency.

Both packages were failing before already.

@turion
Copy link
Contributor Author

turion commented Jun 27, 2020

@jonringer can you review again?

@marsam marsam merged commit 1b2c01a into NixOS:master Jun 28, 2020
@turion turion deleted the 91492_progressbar2 branch June 28, 2020 09:42
@marvin-mk2 marvin-mk2 bot requested a review from timokau July 3, 2020 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

@FRidh FRidh Awaiting requested review from FRidh

@ashgillman ashgillman Awaiting requested review from ashgillman

@timokau timokau Awaiting requested review from timokau

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer awaiting_reviewer marvin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

python37Packages.progressbar2 fails to build with "error: option --addopts not recognized"
3 participants
@turion @jonringer @marsam