haskell: remove obsolete overrides #91435
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svmhdvn
force-pushed
the
clean-overrides
branch
3 times, most recently
from
0e28376
to
69dc7a1
Compare
ofborg
bot
added
10.rebuild-darwin: 11-100
10.rebuild-linux: 11-100
10.rebuild-darwin: 501+
10.rebuild-darwin: 2501-5000
10.rebuild-linux: 501+
10.rebuild-linux: 2501-5000
and removed
10.rebuild-darwin: 1
10.rebuild-darwin: 1-10
10.rebuild-linux: 1
10.rebuild-linux: 1-10
10.rebuild-darwin: 11-100
10.rebuild-linux: 11-100
labels
|
@cdepillabout I will be doing more work on this in the coming days. Would this be better to split up into multiple PRs, perhaps one PR per override removal? Or would you prefer it to be in one large PR? |
|
@svmhdvn Thanks for working on this!
It doesn't really matter, but it is generally easier to review PRs that affect less packages. However, sending one PR per package is somewhat annoying for the person creating PRs, so maybe 3 to 5 overrides per PR is a good compromise? |
|
Sounds good, I'll split it up accordingly. |
peti
force-pushed
the
haskell-updates
branch
3 times, most recently
from
2afb81a
to
c7cadae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Removing obsolete overrides listed by #86500:
Waiting on upstream for PR/hackage push:
Non-obsolete overrides
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)