Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hugo: 0.72.0 -> 0.73.0 #91491

Merged
merged 1 commit into from Jun 25, 2020
Merged

hugo: 0.72.0 -> 0.73.0 #91491

merged 1 commit into from Jun 25, 2020

Conversation

Frostman
Copy link
Member

@Frostman Frostman commented Jun 25, 2020

Motivation for this change

https://github.com/gohugoio/hugo/releases/tag/v0.73.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This change is Reviewable

Copy link
Member

@mdlayher mdlayher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

 $ nixpkgs-review pr 91491
$ git -c fetch.prune=false fetch --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0 pull/91491/head:refs/nixpkgs-review/1
remote: Enumerating objects: 5, done.
remote: Counting objects: 100% (5/5), done.
remote: Total 7 (delta 5), reused 5 (delta 5), pack-reused 2
Unpacking objects: 100% (7/7), 593 bytes | 593.00 KiB/s, done.
From ssh://github.com/NixOS/nixpkgs
 + bda6ab59943...dcd48593e84 refs/pull/91491/head -> refs/nixpkgs-review/1  (forced update)
$ git worktree add /home/matt/.cache/nixpkgs-review/pr-91491/nixpkgs 06f0a0fc27f7c633ae58ff68ccd3bb8b9f0b301f
Preparing worktree (detached HEAD 06f0a0fc27f)
HEAD is now at 06f0a0fc27f linux: 5.7.5 -> 5.7.6
$ git merge --no-commit dcd48593e845c1565251ca9fd2aa43891f2b3748
Automatic merge went well; stopped before committing as requested
$ nix build --no-link --keep-going --option build-use-sandbox relaxed -f /home/matt/.cache/nixpkgs-review/pr-91491/build.nix
[4 built, 2 copied (5.0 MiB), 1.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/91491
1 package built:
hugo

$ nix-shell /home/matt/.cache/nixpkgs-review/pr-91491/shell.nix

[nix-shell:~/.cache/nixpkgs-review/pr-91491]$ ./results/hugo/bin/hugo version
Hugo Static Site Generator v0.73.0/extended linux/amd64 BuildDate: unknown

@Ma27 Ma27 merged commit 3232fd9 into NixOS:master Jun 25, 2020
@Frostman Frostman deleted the hugo-0.73.0 branch June 25, 2020 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants