Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/blockbook-frontend: init #91497

Merged
merged 3 commits into from Jun 26, 2020
Merged

nixos/blockbook-frontend: init #91497

merged 3 commits into from Jun 26, 2020

Conversation

1000101
Copy link
Member

@1000101 1000101 commented Jun 25, 2020

Motivation for this change

Initial definition of blockbook-frontend service - blockchain explorer, its test and a small change to the package itself so we can run this as a service with multiple instances and different blockchains.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@1000101 1000101 requested a review from mmahut June 25, 2020 14:56
@ofborg ofborg bot requested a review from kalbasit June 25, 2020 15:03
@1000101 1000101 marked this pull request as draft June 25, 2020 15:04
@1000101 1000101 requested a review from prusnak June 26, 2020 10:37
@1000101 1000101 marked this pull request as ready for review June 26, 2020 12:36
@1000101
Copy link
Member Author

1000101 commented Jun 26, 2020

@ofborg test blockbook-frontend

@mmahut
Copy link
Member

mmahut commented Jun 26, 2020

Thank you, good work.

@mmahut mmahut merged commit bb7c607 into NixOS:master Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmahut mmahut Awaiting requested review from mmahut

@kalbasit kalbasit Awaiting requested review from kalbasit

@prusnak prusnak Awaiting requested review from prusnak

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@1000101 @mmahut @prusnak