New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pythonPackages.gdown: init at 3.11.1 #91462
Conversation
doCheck = false; | ||
|
||
doInstallCheck = true; | ||
installCheckPhase = '' | ||
$out/bin/gdown --help > /dev/null | ||
''; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
buildPythonApplication's checkPhase maps to installCheckPhase on derviation, and checkPhase = true; is default for python packages
doCheck = false; | |
doInstallCheck = true; | |
installCheckPhase = '' | |
$out/bin/gdown --help > /dev/null | |
''; | |
checkPhase = '' | |
$out/bin/gdown --help > /dev/null | |
''; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I made the changes and updated. I kept the doCheck = false;
there to skip running this module's test.
I tried to force push to the branch to update the PR. Found that there is an extra commit on Thanks! |
|
Huh didn't figure it was that easy. Okay I updated the diff the dropped the unnecessary commit. Thanks @jonringer! |
According to the readme, this is meant to also be used as an application. Do you mind adding the following to
More information on this can be found here |
Thanks for the reference. Added it and tested it with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
diff LGTM
commits LGTM
has tests 👍
https://github.com/NixOS/nixpkgs/pull/91462
3 packages built:
gdown python27Packages.gdown python37Packages.gdown
Thanks a lot @jonringer ! |
Motivation for this change
Add gdown which provides both a CLI tool as well as a python package for downloading artifacts from Google Drive.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)