Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treewide: remove deprecated value Application from makeDesktopItem #91459

Merged
merged 1 commit into from Jun 25, 2020
Merged

treewide: remove deprecated value Application from makeDesktopItem #91459

merged 1 commit into from Jun 25, 2020

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Jun 25, 2020

Motivation for this change
Running desktop-file validation
/nix/store/3mrrr9l2d28xj2j3i8b097fh19xznwlb-firefox.desktop/share/applications/firefox.desktop:
warning: value "Application;Network;WebBrowser;" for key "Categories" in group "Desktop Entry" contains a deprecated value "Application"

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM

@worldofpeace worldofpeace merged commit bdb5938 into NixOS:master Jun 25, 2020
@worldofpeace
Copy link
Contributor

Thank you @zowoq

@zowoq zowoq deleted the desktop-validation branch June 25, 2020 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants