Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nheko 0.7.2 #91490

Merged
merged 2 commits into from Jun 27, 2020
Merged

Nheko 0.7.2 #91490

merged 2 commits into from Jun 27, 2020

Conversation

pstn
Copy link
Contributor

@pstn pstn commented Jun 25, 2020 •
edited

Depends on #90411, commit added here for testing purposes

Motivation for this change

bump nheko version

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nixpkgs-review pr 91490
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from Ekleog and fpletz June 25, 2020 13:15
doronbehar
doronbehar reviewed Jun 26, 2020
View reviewed changes
pkgs/applications/networking/instant-messengers/nheko/default.nix Outdated
@@ -43,15 +43,6 @@ mkDerivation rec {
# https://github.com/NixOS/nixpkgs/pull/73940 are merged
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was merged so it shouldn't be needed as well now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, still builds fine without it.

@doronbehar doronbehar mentioned this pull request Jun 26, 2020
Closed
@pstn
nheko: 0.7.1 -> 0.7.2
02a7121 
Signed-off-by: Philipp <philipp+dev@xndr.de>
@doronbehar
Copy link
Contributor

Please undraft this.

@pstn pstn marked this pull request as ready for review June 26, 2020 08:17
@Ma27 Ma27 merged commit 7f742e4 into NixOS:master Jun 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doronbehar doronbehar doronbehar left review comments

@Ekleog Ekleog Awaiting requested review from Ekleog

@fpletz fpletz Awaiting requested review from fpletz

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pstn @doronbehar @Ma27 @r-ryantm