Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

google-cloud-secret-manager: init at 1.0.0 #91494

Merged
merged 1 commit into from Jun 25, 2020
Merged

google-cloud-secret-manager: init at 1.0.0 #91494

merged 1 commit into from Jun 25, 2020

Conversation

siriobalmelli
Copy link
Contributor

Signed-off-by: Sirio Balmelli sirio@b-ad.ch

Motivation for this change

Require this module for a Nix CI build I maintain.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@siriobalmelli
google-cloud-secret-manager: init at 1.0.0
de77499 
Signed-off-by: Sirio Balmelli <sirio@b-ad.ch>
jonringer
jonringer approved these changes Jun 25, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 91494 1

2 packages built: - python37Packages.google_cloud_secret_manager - python38Packages.google_cloud_secret_manager

@jonringer jonringer merged commit 8c74f97 into NixOS:master Jun 25, 2020
@siriobalmelli siriobalmelli deleted the add/google-cloud-secret-manager branch June 26, 2020 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@siriobalmelli @jonringer