earlyoom: patch absolute dbus path and make nixos module up to date #88443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| description = '' | ||
| Send notifications about killed processes via the system d-bus. | ||
| To actually see the notifications in your GUI session, you need to have | ||
| <literal>systembus-notify</literal> running as your user. |
There was a problem hiding this comment.
Maybe we should package this? Opened rfjakob/systembus-notify#3 for a user service
There was a problem hiding this comment.
See #88441. But is there any way to setup a systemd user service in system configuration?
There was a problem hiding this comment.
It sounds like the autostart desktop file is enough
There was a problem hiding this comment.
(but yes there is, through systemd.user.services I think)
There was a problem hiding this comment.
Should I make environment.systemPackages = [ pkgs.systembus-notify ]; when notification is enabled? But this requires #88441 to be merged first.
There was a problem hiding this comment.
Yeah - let’s do that and merge systembus-notify first
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
earlyoomv1.6 replaces old notification logic withdbus-send/systembus-notify. (See Changelog.)But dbus path is not patched and options of nixos/earlyoom is not up to date.
Related: #88441
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)