Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnucash: Add libdbiDrivers env var to wrapper #88442

Merged
merged 1 commit into from Jun 11, 2020
Merged

gnucash: Add libdbiDrivers env var to wrapper #88442

merged 1 commit into from Jun 11, 2020

Conversation

jasom
Copy link
Contributor

@jasom jasom commented May 20, 2020 •
edited

Motivation for this change

The GNU Cash package clearly wants to be able to use the libdbi
backends, since it pulls them in as dependencies. However, you can only
open xml formatted GNU cash files.

The CMake scripts hard-code the DBD path to be basically
<PATH_OF_LIBDBI>/dbd. However GNU Cash does check the environment
variable GNC_DBD_DIR, so I set that environment variable in the wrapper
script.

With this change, you should be able to e.g. "Save As" in the sqlite
format.

Fixes #57445

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after) not sure why, but it increased the closure size by 17MB
  • Ensured that relevant documentation is up to date No doc changes needed
  • Fits CONTRIBUTING.md.

@jasom
gnucash: Add libdbiDrivers env var to wrapper
93d4bf5 
The GNU Cash package clearly *wants* to be able to use the libdbi
backends, since it pulls them in as dependencies.  However, you can only
open xml formatted GNU cash files.

The CMake scripts hard-code the DVD path to be basically
<PATH_OF_LIBDBI>/dbd.  However GNU Cash does check the environment
variable GNC_DBD_DIR, so I set that environment variable in the wrapper
script.

With this change, you should be able to e.g. "Save As" in the sqlite
format.

Fixes issue NixOS#57445
@jasom jasom force-pushed the gnucash-dbd-location-fix branch from 134f561 to 93d4bf5 Compare May 20, 2020 16:43
@ofborg ofborg bot requested review from domenkozar and peti May 20, 2020 16:52
bjornfor
bjornfor approved these changes May 24, 2020
View reviewed changes
Copy link
Contributor

@bjornfor bjornfor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@bjornfor bjornfor merged commit afb5de4 into NixOS:master Jun 11, 2020
@jasom jasom mentioned this pull request Nov 16, 2020
Closed
@jasom
Copy link
Contributor Author

jasom commented Nov 16, 2020

Fixes #57445

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjornfor bjornfor bjornfor approved these changes

@domenkozar domenkozar Awaiting requested review from domenkozar

@peti peti Awaiting requested review from peti

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gnucash: No suitable backend for sqlite save files
2 participants
@jasom @bjornfor