[Gecko Bug 1584890] Part 1 - Use nsFrameConstructorState::AddChild() to construct out-of-flow flex or grid container as the root element. #23720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
May 20, 2020
moz-wptsync-bot
force-pushed
the
gecko/1584890
branch
from
ba37b71
to
8701bd9
Compare
…flow flex or grid container as the root element. If `contentFrame` is out-of-flow, nsFrameConstructorState::AddChild() can construct a placeholder frame for `contentFrame` and put the placeholder in `frameList`. Also, we need to use nsFrameConstructorState::GetGeometricParent() to get the correct parent when calling InitAndRestoreFrame() for an out-of-flow `contentFrame`. For example, if `contentFrame` has position:fixed, its parent should be ViewportFrame, not CanvasFrame (which is mDocElementContainingBlock). This patch also adds reftests for position:absolute flex & grid root element. Reftests for position:fixed root element are in the next part. Differential Revision: https://phabricator.services.mozilla.com/D76205 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1584890 gecko-commit: 19b910256abfe62d1fcb177e48ed1c1a28f5b2ab gecko-integration-branch: autoland gecko-reviewers: dholbert
Differential Revision: https://phabricator.services.mozilla.com/D76206 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1584890 gecko-commit: a00f71376ad18b3cde3d92b338b5304c7ffd7334 gecko-integration-branch: autoland gecko-reviewers: dholbert
moz-wptsync-bot
force-pushed
the
gecko/1584890
branch
from
8701bd9
to
3372086
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
contentFrameis out-of-flow, nsFrameConstructorState::AddChild() canconstruct a placeholder frame for
contentFrameand put the placeholder inframeList.Also, we need to use nsFrameConstructorState::GetGeometricParent() to
get the correct parent when calling InitAndRestoreFrame() for an
out-of-flow
contentFrame. For example, ifcontentFramehasposition:fixed, its parent should be ViewportFrame, not
CanvasFrame (which is mDocElementContainingBlock).
This patch also adds reftests for position:absolute flex & grid root
element. Reftests for position:fixed root element are in the next part.
Differential Revision: https://phabricator.services.mozilla.com/D76205
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1584890
gecko-commit: 84d138356c7699456abf8dc6483b1d49aab86771
gecko-integration-branch: autoland
gecko-reviewers: dholbert