Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/hydra
base: 03f14f46d737
Choose a base ref
...
head repository: NixOS/hydra
compare: 3c6b724f9211
Choose a head ref
  • 2 commits
  • 1 file changed
  • 2 contributors

Commits on May 20, 2020

  1. Render the jobset page correctly when there are fetch errors

    The original code would return standard "Please come back later" page when there
    are only fetch errors on a newly setup declarative project. The problem is that
    there are two types of errors: standard errors and fetch errors. Each is
    acompanied by a corresponding field for time of occurence. Standard errors use
    'errortime', while fetch errors have 'lastchecktime' set to the time of the
    error. Unfortunately, jobset.tt file was only using 'errortime' for displaying
    the time. This would result in the following errors in logs:
    
        Couldn't render template "date error - bad time/date string:  expects 'h:m:s d:m:y'  got: ''
    
    This change includes using 'lastchecktime' when rendering the error times.
    knl committed May 20, 2020
    Copy the full SHA
    0f21e40 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #764 from knl/render-jobset.tt-correctly

    Render the jobset page correctly when there are fetch errors
    basvandijk committed May 20, 2020
    Copy the full SHA
    3c6b724 View commit details
    Browse the repository at this point in the history