Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker: 19.03.8 -> 19.03.9 #88445

Merged
merged 1 commit into from May 21, 2020
Merged

docker: 19.03.8 -> 19.03.9 #88445

merged 1 commit into from May 21, 2020

Conversation

Frostman
Copy link
Member

@Frostman Frostman commented May 20, 2020 •
edited

Motivation for this change

https://github.com/docker/docker-ce/releases/tag/v19.03.9

Things done

nixosTests.docker passed

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This change is Reviewable

@offlinehacker offlinehacker merged commit 9d0e884 into NixOS:master May 21, 2020
@Frostman Frostman deleted the docker-19.03.9 branch May 21, 2020 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@offlinehacker offlinehacker offlinehacker approved these changes

@tailhook tailhook Awaiting requested review from tailhook

@NeQuissimus NeQuissimus Awaiting requested review from NeQuissimus

@vdemeester vdemeester Awaiting requested review from vdemeester

@periklis periklis Awaiting requested review from periklis

Assignees
No one assigned
Labels
8.has: documentation 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Frostman @offlinehacker