Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocamlPackages.curly: init at 2019-11-14 #88463

Merged
merged 1 commit into from May 26, 2020

Conversation

sternenseemann
Copy link
Member

Motivation for this change

Dependency for dune-release which I am working on packaging. Used a unstable version, since the last release's jbuilder setup seems broken by now and the old API isn't broken.

I decided to patch in a static path to curl, since curly assumes that it'll find curl in PATH by default, which is kind of hard to ensure for a library. The static path can still be overridden by the user of the library if they want to, however.

Another solution to the problem could be to not care about it in curly, but use wrapProgram for all user applications that use curly and add curl to PATH there. I think doing it in curly is nicer overall and should ensure that it works out of the box, but let me know what you think!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@vbgl
Copy link
Contributor

vbgl commented May 25, 2020

@GrahamcOfBorg build ocamlPackages.curly

@vbgl vbgl merged commit 9d33cb4 into NixOS:master May 26, 2020
@sternenseemann sternenseemann deleted the curly-2019-11-14 branch May 26, 2020 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants