ocamlPackages.curly: init at 2019-11-14 #88463
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Dependency for dune-release which I am working on packaging. Used a unstable version, since the last release's jbuilder setup seems broken by now and the old API isn't broken.
I decided to patch in a static path to
curl
, sincecurly
assumes that it'll findcurl
inPATH
by default, which is kind of hard to ensure for a library. The static path can still be overridden by the user of the library if they want to, however.Another solution to the problem could be to not care about it in
curly
, but usewrapProgram
for all user applications that usecurly
and addcurl
toPATH
there. I think doing it incurly
is nicer overall and should ensure that it works out of the box, but let me know what you think!Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)