@orivej-nixos did you test your changes and will you merge this PR? Please don't just add commits without any comment.

And FYI: Building shared libraries should probably be tested on Darwin again as this apparently caused problems in the past: d349cfe

@GrahamcOfBorg build ffmpeg_4

Yeah, I've lost track of this. I have tested building ffmpeg-full and running aomenc on Linux. At the moment I can not test on macOS, I hope the bot will confirm that it builds, since the previous shared lib error was a build failure (#52444 (comment)).

(Building ffmpeg_4 inadvertently tests building libaom due to https://github.com/NixOS/nixpkgs/pull/72941/files#r429495248. ffmpeg-full would not include libaom support without it.)

Unfortunately staging was broken, I'll temporarily switch to master; while building python3.pkgs.cython:

/nix/store/ri3b04wqx51r3xf2l7z1gz24kr299ks1-python3.7-pkgconfig-1.5.1/nix-support/setup-hook: line 61: export: `NIX_@wrapperName@_TARGET_HOST_@suffixSalt@=1': not a valid identifier

@GrahamcOfBorg build libaom ffmpeg_4

aa44ca3 should prevent future libaom updates from triggering a mass rebuild.

@orivej Thanks

aa44ca3 should prevent future libaom updates from triggering a mass rebuild.

Nice, that explains it :) I was surprised that this caused so many rebuilds as IIRC mainly ffmpeg-full depends on it, but I forgot to have a closer look.

Edit: Oh and btw would you mind trying to upstream your patch/fix?

Aomedia patch submission seems too convoluted. Feel free to submit it as if you wrote it yourself. The only thing I would change is set exec_prefix to ${prefix} (literally, as it was before my patch) in case prefix and exec_prefix are the same, so that other distributions will see the usual exec_prefix=${prefix} in their .pc.

Aomedia patch submission seems too convoluted.

Unfortunately :o

Feel free to submit it as if you wrote it yourself.

Ok, thanks, I'll look into that then.