Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.stack-data: init at 0.0.7 #88494

Merged
merged 2 commits into from Nov 20, 2020
Merged

pythonPackages.stack-data: init at 0.0.7 #88494

merged 2 commits into from Nov 20, 2020

Conversation

jluttine
Copy link
Member

@jluttine jluttine commented May 21, 2020 •
edited

Motivation for this change

Add Python package stack-data and its dependencies.

IPython will soon need this dependency: https://github.com/ipython/ipython/blob/master/setup.py#L194 (permalink https://github.com/ipython/ipython/blob/a483781c6e480b18b6cdc78a9851c23cd528a890/setup.py#L194), so with this PR stack-data would be readily available in nixpkgs when IPython release will depend on stack-data. I needed to add this to nixpkgs already now because I was using master branch of IPython locally. So I thought I'd provide a PR for these upcoming dependencies.

I'll run nixpkgs-review soon.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jluttine
Copy link
Member Author

nixpkgs-review passed

@jluttine
Copy link
Member Author

I now rebased on master. While this PR has been waiting for half a year now, someone else had added a few packages that I had in this PR, namely pure-eval and executing. So, some duplicate work gone to waste. Anyway, two new packages still remain in this PR.

jonringer
jonringer approved these changes Nov 20, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 88494 1

5 packages built:
  • python27Packages.littleutils
  • python37Packages.littleutils
  • python37Packages.stack-data
  • python38Packages.littleutils
  • python38Packages.stack-data

@jonringer jonringer merged commit 854f78d into NixOS:master Nov 20, 2020
@jluttine
Copy link
Member Author

@jonringer Great, thanks a lot for the review! 👌

@jluttine
Copy link
Member Author

Oh, I realized pname = "stack_data" should have been normalized to pname = "stack-data" and then repo = "stack_data".. Should I still fix that or leave it as it is?

@jonringer
Copy link
Contributor

Oh, I realized pname = "stack_data" should have been normalized to pname = "stack-data" and then repo = "stack_data".. Should I still fix that or leave it as it is?

That's more for the "attr" in python-modules.nix, the pname can match what's on pypi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jluttine @jonringer @ryantm