Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

systembus-notify: init at 1.0 #88441

Merged
merged 2 commits into from May 24, 2020
Merged

systembus-notify: init at 1.0 #88441

merged 2 commits into from May 24, 2020

Conversation

oxalica
Copy link
Contributor

@oxalica oxalica commented May 20, 2020 •
edited

Motivation for this change

Add a new package systembus-notify which works with earlyoom for desktop notifications.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
    • 35.7 MiB
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@oxalica oxalica mentioned this pull request May 20, 2020
Merged
10 tasks
matthewbauer
matthewbauer reviewed May 22, 2020
View reviewed changes
pkgs/applications/misc/systembus-notify/default.nix Outdated
installPhase = ''
runHook preInstall
install -Dm755 systembus-notify -t $out/bin
install -Dm644 systembus-notify.desktop -t $out/share/applications
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should go in $out/etc/xdg/autostart/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If so, is there any way to disable it manually?
And I'm not sure whether $out/etc/xdg/autostart will work for user installation through nix-env -i.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-env should work provided you have $HOME/.nix-profile/etc/xdg in XDG_CONFIG_DIRS. It's pretty standard for apps to do this (see /run/current-system/sw/etc/xdg/autostart for some examples). This also matches what is in the install rule of the Makefile (although it references $HOME).

@oxalica oxalica requested a review from matthewbauer May 24, 2020 05:58
@matthewbauer matthewbauer merged commit b53605a into NixOS:master May 24, 2020
@oxalica oxalica deleted the systembus-notify branch May 25, 2020 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@oxalica @matthewbauer