Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

notepadqq: remove unnecesary fetchSubmodules #88452

Merged
merged 1 commit into from Jun 14, 2020
Merged

notepadqq: remove unnecesary fetchSubmodules #88452

merged 1 commit into from Jun 14, 2020

Conversation

bhipple
Copy link
Contributor

@bhipple bhipple commented May 20, 2020

There are none to fetch, as verified by changing the hash and retrying. This
will now use the faster fetchzip path through fetchFromGitHub.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bhipple
notepadqq: remoe unnecesary fetchSubmodules
32017fb 
There are none to fetch, as verified by changing the hash and retrying. This
will now use the faster fetchzip path through fetchFromGitHub.
@bhipple bhipple changed the title notepadqq: remoe unnecesary fetchSubmodules notepadqq: remove unnecesary fetchSubmodules May 20, 2020
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/177

@bhipple bhipple merged commit bfa7b0c into NixOS:master Jun 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bhipple @nixos-discourse