Clipboard API: Implement clipboard-read and clipboard-write Feature Policy. #23727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
May 21, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2164248
branch
3 times, most recently
from
29eb26a
to
151485f
Compare
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2164248
branch
3 times, most recently
from
3bf54b9
to
0240864
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2164248
branch
from
0240864
to
1cdb3df
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2164248
branch
from
1cdb3df
to
08975cb
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2164248
branch
2 times, most recently
from
3e8379f
to
d596f0a
Compare
…olicy. Complete and expose previously incomplete feature policy integration. Also, use separate clipboard-read and clipboard-write feature policies, as opposed to the previous single clipboard feature policy. Previously, https://crrev.com/c/1913466 aimed to add Feature Policy integration to the Clipboard API. Unfortunately, this integration wasn't complete, so sites didn't have the option to allow cross-origin iframes to access the clipboard at all after this change. Complete the integration to allow sites to enable this feature policy. Also, as feature and permission policies are being merged, use clipboard-read and clipboard-write as feature policy names, so that the feature policy and permission names match. Verified by via automated WPTs, and also manually tested by running this example[1], which fails without this CL, and succeeds with the CL. Intent to prototype and ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/IDAapW6w4to/iSH1MXRFCgAJ [1]: https://smart-flicker-baroness.glitch.me/ Bug: 1074489 Change-Id: I09125d74510ed6c868d84936df595d02326619b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164248 Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Reviewed-by: Alex Russell <slightlyoff@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Ian Clelland <iclelland@chromium.org> Reviewed-by: Balazs Engedy <engedy@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#786914}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2164248
branch
from
d596f0a
to
13c3808
Compare
|
Tests seem flaky.
|
|
Filed https://bugs.chromium.org/p/chromium/issues/detail?id=1104219 and force merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complete and expose previously incomplete feature policy integration.
Also, use separate clipboard-read and clipboard-write feature policies,
as opposed to the previous single clipboard feature policy.
Previously, https://crrev.com/c/1913466 aimed to add Feature Policy
integration to the Clipboard API. Unfortunately, this integration wasn't
complete, so sites didn't have the option to allow cross-origin iframes
to access the clipboard at all after this change.
Complete the integration to allow sites to enable this feature policy.
Also, as feature and permission policies are being merged, use
clipboard-read and clipboard-write as feature policy names, so that the
feature policy and permission names match.
Verified by via automated WPTs, and also manually tested by running this
example1, which fails without this CL, and succeeds with the CL.
Intent to prototype and ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/IDAapW6w4to/iSH1MXRFCgAJ
Bug: 1074489
Change-Id: I09125d74510ed6c868d84936df595d02326619b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164248
Commit-Queue: Darwin Huang <huangdarwin@chromium.org>
Reviewed-by: Alex Russell <slightlyoff@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786914}