Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some parameters affected in "Property Browser" by changing "digits after decimal point to show" #619

Closed
ghost opened this issue May 21, 2020 · 4 comments
Closed

Some parameters affected in "Property Browser" by changing "digits after decimal point to show" #619

ghost opened this issue May 21, 2020 · 4 comments
Labels
question

Comments

@ghost
Copy link

ghost commented May 21, 2020 •
edited by ghost

System information

  • SolveSpace version: 3.0~70ec7cc2
  • Operating system: Debian 10 buster

Expected behavior

Changing "digits after decimal point to show" should not affect properties fields on "Property Browser".

Actual behavior

Some properties fields in "Property Browser" affected by changing "digits after decimal point to show".

For example, if set "digits after decimal point to show > distances: 0" some properties values lover than 1.0 (e.g. 0.5) would be shown as 0, but as those properties are important settings such thing should not happen:

pic.1

Affected fields in "Property Browser":

  • on "view" tab:
    • "origin (maps to center of screen";
  • on "configuration" tab:
    • "snap grid spacing";
    • "cutter radius offset (0 = no offset)"
    • export canvas margins:
      • "left";
      • "right";
      • "bottom";
      • "top".
    • exported g code parameters:
      • "depth";
      • "feed";
      • "plunge fd".

Additional information

For bugs, please attach a savefile that shows the problematic behavior.
You can attach .slvs files by archiving them into a .zip first.
@whitequark
Copy link
Contributor

Hm, that's an issue, but it's not clear to me what precision we should use here.

@ghost
Copy link
Author

ghost commented May 21, 2020 •
edited by ghost

but it's not clear to me what precision we should use here.

I suggest <= 8 digits as next:

  • x.1234567890 -> x.12345678 — cut to 8 digits (maximum) without decimation;
  • x.0010000000 -> x.001 — cut to last non-zero digit;
  • x.0000000001 -> x (or x.0) — cut to integer (or to one digit after decimal point) if first 8 digits are zero.

@whitequark
Copy link
Contributor

IIRC, changing the amount of decimals depending on the value itself is troublesome to do with the way the text window is currently implemented.

@ruevs ruevs mentioned this issue Dec 6, 2020
Closed
@phkahler
Copy link
Member

This was fixed in #884 at least well enough to not show 0 when a value is not 0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@whitequark @phkahler