Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ffsend: don't require openssl on darwin #88468

Merged
merged 1 commit into from
May 21, 2020
Merged

ffsend: don't require openssl on darwin #88468

merged 1 commit into from
May 21, 2020
+3 −3

Conversation

lilyball
Copy link
Member

Motivation for this change

ffsend no longer requires openssl on macOS so we should stop declaring this dependency.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@lilyball
ffsend: don't require openssl on darwin

Verified

This commit was signed with the committer’s verified signature. The key has expired.
mweinelt Martin Weinelt
GPG key ID: BD4AA0528F63F17E
Expired
Verified
Learn about vigilant mode
2915242 
The current version of ffsend no longer requires `openssl` on macOS.
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label May 20, 2020
@ofborg ofborg bot requested a review from equirosa May 20, 2020 23:36
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels May 20, 2020
@marsam marsam merged commit 9caecc8 into NixOS:master May 21, 2020
@lilyball lilyball deleted the ffsend branch May 21, 2020 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@equirosa equirosa

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lilyball @marsam