Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] pythonPackages.fritzconnection: 0.8.4 -> 1.2.1 #88501

Merged
merged 2 commits into from May 22, 2020
Merged

[20.03] pythonPackages.fritzconnection: 0.8.4 -> 1.2.1 #88501

merged 2 commits into from May 22, 2020

Conversation

jokogr
Copy link
Contributor

@jokogr jokogr commented May 21, 2020

Motivation for this change

Backport #83451 to 20.03. There were a couple of conflicts that were easily solved.

The compiled package seems to be working, I've run the code mentioned in the official documentation:

$ python test.py
FRITZ!Box 7530 at http://192.168.178.1
FRITZ!OS: 7.14
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jokogr jokogr changed the title pythonPackages.fritzconnection: 0.8.4 -> 1.2.1 [20.03] pythonPackages.fritzconnection: 0.8.4 -> 1.2.1 May 21, 2020
@Valodim
Copy link
Contributor

Valodim commented May 21, 2020

seems my maintainer entry isn't yet in 20.03. my first PR was merged Feb14, seems I barely missed it ;) You can include 52ac65c in this PR to backport it.

lgtm otherwise 👍

@jokogr jokogr force-pushed the u/fritzconnection-1.2.1-20.03 branch from 1439bf3 to 0edf164 Compare May 21, 2020 10:14
@ofborg ofborg bot requested review from dotlambda and Valodim May 21, 2020 10:21
@jokogr jokogr merged commit 48723f4 into NixOS:release-20.03 May 22, 2020
@jokogr jokogr deleted the u/fritzconnection-1.2.1-20.03 branch May 22, 2020 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Valodim Valodim Valodim approved these changes

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

@jonringer jonringer Awaiting requested review from jonringer jonringer is a code owner

@dotlambda dotlambda Awaiting requested review from dotlambda

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jokogr @Valodim