Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rivet: 2.7.2 -> 3.1.1 #88476

Merged
merged 4 commits into from May 26, 2020
Merged

rivet: 2.7.2 -> 3.1.1 #88476

merged 4 commits into from May 26, 2020

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented May 21, 2020

Motivation for this change

Update Rivet to the latest version

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@veprbl veprbl force-pushed the pr/rivet3 branch 2 times, most recently from b9ac198 to 4229bac Compare May 23, 2020 21:44
@veprbl veprbl changed the title WIP rivet: 2.7.2 -> 3.1.1 rivet: 2.7.2 -> 3.1.1 May 23, 2020
@veprbl veprbl merged commit 5035c65 into NixOS:master May 26, 2020
@veprbl veprbl deleted the pr/rivet3 branch December 1, 2020 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant