Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linux config: SND_HDA_CODEC_CA0132_DSP for <5.7 #85426

Merged
merged 1 commit into from Jun 15, 2020
Merged

linux config: SND_HDA_CODEC_CA0132_DSP for <5.7 #85426

merged 1 commit into from Jun 15, 2020

Conversation

Emantor
Copy link
Member

@Emantor Emantor commented Apr 17, 2020 •
edited

Motivation for this change

The default enable for SND_HDA_CODEC_CA0132_DSP was already merged into
5.7-rc1 (1), which means we can adjust the whenOlder to 5.7.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Emantor
linux config: SND_HDA_CODEC_CA0132_DSP for <5.7
4302dc7 
The default enable for SND_HDA_CODEC_CA0132_DSP was already merged into
5.7-rc1 [1], which means we can adjust the whenOlder to 5.7.

[1]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=652bb5d8df4b3a79ed350db35cda12637e63efa7
@teto
Copy link
Member

teto commented Apr 17, 2020

could you add the requested information in "Requesting a change in the default nixos kernel configuration" https://nixos.wiki/wiki/Linux_kernel please ?

@Emantor
Copy link
Member Author

Emantor commented Apr 17, 2020

Since I am neither removing nor adding a new configuration option, IMO it wouldn't make much sense to link the individual distribution kernel configurations here. This adjusts only the whenOlder condition to be inline with the default being enabled upstream.

@teto
Copy link
Member

teto commented Apr 17, 2020

oh yeah my bad sry

@Emantor
Copy link
Member Author

Emantor commented Jun 15, 2020

Mentioning @flokli for merge 😁

@teto teto merged commit 407a3d4 into NixOS:staging Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Emantor @teto