Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chromedriver: 78.0.3904.70 -> 81.0.4044.69 #85353

Merged
merged 1 commit into from Apr 16, 2020
Merged

chromedriver: 78.0.3904.70 -> 81.0.4044.69 #85353

merged 1 commit into from Apr 16, 2020

Conversation

das-g
Copy link
Member

@das-g das-g commented Apr 16, 2020

backport of #85302

Motivation for this change

Bring in sync with chromium version, so that chromedriver and chromium can be used together. See https://chromedriver.chromium.org/downloads/version-selection

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix run -f . nixpkgs-review -c nixpkgs-review wip -b release-20.03
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Result of nixpkgs-review 1

1 package marked as broken and skipped:
  • self
3 package built:
  • chromedriver
  • selendroid
  • selenium-server-standalone

@ofborg ofborg bot requested review from cillianderoiste and marsam April 16, 2020 03:29
@marsam marsam merged commit 3abf820 into NixOS:release-20.03 Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cillianderoiste cillianderoiste Awaiting requested review from cillianderoiste

@marsam marsam Awaiting requested review from marsam

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@das-g @marsam