Skip to content
This repository has been archived by the owner on Apr 12, 2021. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs-channels
base: 900b58e4eed2
Choose a base ref
...
head repository: NixOS/nixpkgs-channels
compare: 2ee6b5ce7c3f
Choose a head ref
  • 2 commits
  • 1 file changed
  • 2 contributors

Commits on Apr 16, 2020

  1. Revert "nixos/acme: Fix allowKeysForGroup not applying immediately" 

    This reverts commit 5532065.

As far as I can tell setting RemainAfterExit=true here completely breaks
certificate renewal, which is really bad!

the sytemd timer will activate the service unit every OnCalendar=,
however with RemainAfterExit=true the service is already active! So the
timer doesn't rerun the service!

The commit also broke the actual tests, (As it broke activation too)
but this was fixed later in NixOS/nixpkgs#76052
I wrongly assumed that PR fixed renewal too, which it didn't!

testing renewals is hard, as we need to sleep in tests.
    @arianvp
    arianvp committed Apr 16, 2020
    Copy the full SHA
    c51c677 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #85333 from arianvp/revert-acme-backport 

    [20.03] Revert "nixos/acme: Fix allowKeysForGroup not applying immediately"
    @worldofpeace
    worldofpeace committed Apr 16, 2020
    Copy the full SHA
    2ee6b5c View commit details
    Browse the repository at this point in the history