Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

babashka: 0.78 -> 0.85 #85393

Closed
wants to merge 1 commit into from
Closed

babashka: 0.78 -> 0.85 #85393

wants to merge 1 commit into from

Conversation

bfortz
Copy link
Contributor

@bfortz bfortz commented Apr 16, 2020

Motivation for this change

Fixed UTF-8 bug
babashka/babashka#359

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bfortz
babashka: 0.78 -> 0.85
33f269a 
Fixed UTF-8 bug
@ofborg ofborg bot requested a review from jlesquembre April 16, 2020 18:41
@bennyandresen
Copy link
Contributor

The regular version bump is a duplicate of #84350

But you also found and fixed a utf-8 bug which I incorporated into the above PR, as it has additional changes from previous attempts at pull requests. :-)

@bennyandresen bennyandresen mentioned this pull request Apr 21, 2020
Merged
10 tasks
@bfortz bfortz closed this Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlesquembre jlesquembre Awaiting requested review from jlesquembre

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bfortz @bennyandresen