Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19.09] chromedriver: 80.0.3987.16 -> 81.0.4044.69 #85351

Closed
wants to merge 1 commit into from
Closed

[19.09] chromedriver: 80.0.3987.16 -> 81.0.4044.69 #85351

wants to merge 1 commit into from

Conversation

das-g
Copy link
Member

@das-g das-g commented Apr 16, 2020 •
edited

backport of #85302

Motivation for this change

Bring in sync with chromium version, so that chromedriver and chromium can be used together. See https://chromedriver.chromium.org/downloads/version-selection

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix run -f . nixpkgs-review -c nixpkgs-review wip -b release-19.09
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Result of nixpkgs-review 1

1 package marked as broken and skipped:
  • self
3 package built:
  • chromedriver
  • selendroid
  • selenium-server-standalone

@das-g das-g changed the title chromedriver: 80.0.3987.16 -> 81.0.4044.69 [19.09] chromedriver: 80.0.3987.16 -> 81.0.4044.69 Apr 16, 2020
@ofborg ofborg bot requested a review from cillianderoiste April 16, 2020 03:09
@das-g das-g force-pushed the release-19.09_chromedriver-81.0.4044 branch from 3dc665b to 347f887 Compare April 16, 2020 03:13
@endgame
Copy link
Contributor

endgame commented Sep 2, 2020

Is this still relevant, or could it be closed? (I stumbled upon it while looking for chromedriver PRs)

@das-g
Copy link
Member Author

das-g commented Sep 2, 2020

Is this still relevant, or could it be closed? (I stumbled upon it while looking for chromedriver PRs)

It's not relevant to me anymore, as I've moved on to NixOS 20.03 and later even to unstable.

But as there still might be users of NixOS 19.09 and as this might still be relevant to them, I've left the PR open. I've just checked and this PR would still bring the chromedriver version in that channel in sync with the chromium version there. (Though, that chromium version is now marked as insecure, so I don't know how much that's worth.)

@worldofpeace
Copy link
Contributor

19.09 is EOL and I don't think we accept changes for it anymore. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cillianderoiste cillianderoiste Awaiting requested review from cillianderoiste

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@das-g @endgame @worldofpeace