racket: use --enable-useprefix configure flag. #85385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to fix a regression in upstream Racket packaging, the upstream bug tracking this is here: racket/racket#3046 When the bug is fixed this workaround will be unnecessary.
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/racket-does-not-find-documentation-after-update/6712/9 |
|
As I told @NinjaTrappeur on Discourse, I tested the change in this pull request in my local checkout of Nixpkgs and it fixed the problems I had with Racket finding docs. For the reference, the call |
picnoir
approved these changes
Apr 17, 2020
There was a problem hiding this comment.
Thanks for the PR. I think this is the way to go for now. (see https://discourse.nixos.org/t/racket-does-not-find-documentation-after-update/6712/6?u=ninjatrappeur for more info)
Tested locally, LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has a workaround for a regression in upstream Racket packaging, the upstream bug tracking this is here:
racket/racket#3046
Some relevant discussion of this issue can be found here:
https://discourse.nixos.org/t/racket-does-not-find-documentation-after-update/6712/6
Motivation for this change
The upstream regression causes install locations in the package to be inconsistent with expectations (e.g., docs).
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)