Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skopeo: cleanup #85414

Merged
merged 2 commits into from Apr 19, 2020
Merged

skopeo: cleanup #85414

merged 2 commits into from Apr 19, 2020

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Apr 17, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

saschagrunert
saschagrunert approved these changes Apr 17, 2020
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nlewo
nlewo requested changes Apr 17, 2020
View reviewed changes
pkgs/development/tools/skopeo/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/skopeo/default.nix Outdated Show resolved Hide resolved
@ofborg ofborg bot requested review from nlewo and saschagrunert April 17, 2020 07:42
@Mic92
Copy link
Member

Mic92 commented Apr 17, 2020

@GrahamcOfBorg build skopeo

@zowoq
Copy link
Contributor Author

zowoq commented Apr 17, 2020

Builds for me on darwin, ofborg failure looks random?

@Mic92 Mic92 merged commit d96959a into NixOS:master Apr 19, 2020
@zowoq zowoq deleted the skopeo branch April 19, 2020 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@vdemeester vdemeester Awaiting requested review from vdemeester

@nlewo nlewo Awaiting requested review from nlewo

@saschagrunert saschagrunert Awaiting requested review from saschagrunert

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zowoq @Mic92 @saschagrunert @nlewo