Mark broken master #85417
Mark broken master #85417
Conversation
worldofpeace
requested review from
cdepillabout,
FRidh,
infinisil,
jonringer and
ttuegel
as code owners
|
Need to unmark #85415. Really might need to put a sign up to not conflict with this work. |
this is fixed on master
| @@ -93,5 +93,6 @@ buildPythonPackage rec { | |||
| license = licenses.bsd3; | |||
| maintainers = with maintainers; [ drewkett marsam ]; | |||
| platforms = platforms.unix; | |||
| broken = true; | |||
There was a problem hiding this comment.
scrapy is not broken:
- x86_64-linux: https://hydra.nixos.org/build/116062539
- x86_64-darwin: https://hydra.nixos.org/build/116118595
There was a problem hiding this comment.
Yeah. Looks like a pattern. Same as in https://github.com/NixOS/nixpkgs/pull/85417/files#r410125598
There was a problem hiding this comment.
Is it broken on release-20.03 though?
There was a problem hiding this comment.
I usually look whether something is broken by editing these urls:
https://hydra.nixos.org/jobset/nixos/release-20.03/jobs-tab?filter=scrapy
https://hydra.nixos.org/jobset/nixpkgs/trunk/jobs-tab?filter=scrapy
| @@ -42,5 +42,6 @@ stdenv.mkDerivation rec { | |||
| ''; | |||
| license = licenses.gpl2Plus; | |||
| maintainers = with maintainers; [ orivej ]; | |||
| broken = true; | |||
There was a problem hiding this comment.
Please don't mark muse; backport of the fixes: #85424
| @@ -79,5 +79,6 @@ buildPythonPackage rec { | |||
| homepage = "https://mitmproxy.org/"; | |||
| license = licenses.mit; | |||
| maintainers = with maintainers; [ fpletz kamilchm ]; | |||
| broken = true; | |||
There was a problem hiding this comment.
mitmproxy is not at fault for the failure of its TestMasterSecretLogger.test_log on release-20.03. It does not fail on master, yet there is no difference between mitmproxy definitions between release-20.03 and master.
| @@ -57,5 +57,6 @@ stdenv.mkDerivation rec { | |||
| license = with licenses; [ asl20 bsd3 gpl2 lgpl21 lgpl21Plus openldap ]; | |||
| platforms = [ "x86_64-linux" ]; | |||
| maintainers = with maintainers; [ markuskowa ]; | |||
| broken = true; | |||
There was a problem hiding this comment.
Problem is addressed in this open PR: #81980.
Please don't mark broken just yet.
| @@ -39,5 +40,6 @@ buildPythonPackage rec { | |||
| description = "Command-line tool and library to interact with an aria2c daemon process with JSON-RPC"; | |||
| license = licenses.isc; | |||
| maintainers = with maintainers; [ koral ]; | |||
| broken = isPy38; | |||
There was a problem hiding this comment.
We use disabled = isPy38 instead of broken for pythonPackages.
cc @FRidh
| @@ -34,5 +34,6 @@ buildPythonPackage rec { | |||
| description = "A Python 2 and 3 asynchronous JSON RPC server"; | |||
| license = licenses.mit; | |||
| maintainers = [ maintainers.mic92 ]; | |||
| broken = true; | |||
There was a problem hiding this comment.
This one is not broken afaik. It is needed for the python-language-server,
which is important.
Build Status for nixpkgs.python36Packages.python-jsonrpc-server.x86_64-linux on unstable
✔ python3.6-python-jsonrpc-server-0.0.2 from 2018-10-24 - https://hydra.nixos.org/build/83221618
Tested for all python versions!
|
paperwork is not broken, see #85436 |
| @@ -20,5 +20,6 @@ buildGoModule rec { | |||
| homepage = "https://github.com/nektos/act"; | |||
| license = licenses.mit; | |||
| maintainers = with maintainers; [ filalex77 ]; | |||
| broken = true; | |||
There was a problem hiding this comment.
I also repaired this one quiet recently.
Should be not broken as well.
|
python3Packages.spyder is not broken on master (#83038). |
| @@ -53,5 +53,6 @@ stdenv.mkDerivation rec { | |||
| maintainers = with maintainers; [ etu ]; | |||
| license = licenses.gpl2; | |||
| platforms = platforms.linux; | |||
| broken = true; | |||
There was a problem hiding this comment.
surf-display is not broken on master: https://hydra.nixos.org/jobset/nixpkgs/trunk/jobs-tab?filter=surf-display
|
With some feedback from some community members, forward porting such changes to master isn't going to be very fruitful. Hoping to have automated mark as broken soon. |
Motivation for this change
Forward port the thing #85331
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)